gh-139716: StackRef tests are added #139717
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Why not put this under test-capi?
There was a problem hiding this comment.
I'm not against other directory or file for this test. But test-capi doesn't sound like a best choice, since it's internal API, not public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New test file
Lib/test/test_stackrefs.pyintroduced.Some auxillary functions are added to
_testinternalcapi.Those functions are examples of correct
StackRefscenarios.We check that all
refcountsremain correct.And that results are the same for equivalent scenarios.
PyStackReffunctions #139716